joinmarket-clientserver

Bitcoin CoinJoin implementation with incentive structure to convince people to take part

View the Project on GitHub JoinMarket-Org/joinmarket-clientserver

This will serve as a high level overview of future changes either in progress or planned. The Issues list is for specific bugs or feature requests.

Python

A note on the above - took a look at it last December, but had problems in particular with some twisted elements, specifically txsocksx Done as of 0.4.2, now switched to txtorcon.

Testing

Architecture

* Probably move all user data to ~ ; see comment.

This was done as of v0.6.2

Blockchain

Joinmarket protocol

The fidelity bond code introduced in #544 can serve as a basis for removing this issue, but it will most sensibly fold into a broader protocol upgrade.

Done as of v0.9.5. Makers now use fidelity bonds.

* bech32 addresses for joins; possibly mixed address types, needs discussion.

Bech32 native segwit has become default for coinjoins as of 0.8.0.

An additional possibility is discussesd in #415 namely, possible decentralized architecture for Joinmarket inter-participant communication.

This is done as of v0.9.6, we now have redundant directory nodes and peer to peer transaction negotiation over Tor, albeit it will doubtless require considerable refinement over time.

Qt GUI

* Binary build process automated and, more importantly, working for Linux, Windows and Mac.

There is no current process for building binaries on Mac or Windows (theoretically the latter is possible but a mess, so I’m not doing it).

Windows binaries are now being built in an automated way via #641. The same process for Mac does not yet exist, however (though it is probably fairly feasible).

Alternative implementations

This can now be considered ‘done’ as per the full RPC spec at https://joinmarket-org.github.io/joinmarket-clientserver/api/ based on the daemon scripts/jmwalletd.py which now offers almost all of the functionality of Joinmarket, and the JAM client at https://github.com/joinmarket-webui/joinmarket-webui

Bitcoin

We use coincurve as a binding to libsecp256k1. The current jmbitcoin package morphed over many iterations from the original pybitcointools base code. We need to rework it considerably as it is very messy architecturally, particularly in regard to data types. A full rewrite is likely the best option, including in particular the removal of data type flexibility; use binary only within the package (which will also require rewrite and simplification of some parts of the wallet code).

A rewrite of the transaction signing portion of the jmbitcoin code will need to account for the future probable need to support taproot and Schnorr (without yet implementing it).

This was all done in the switch to python-bitcointx included in 0.7.0 via #536 . Complete removal of coincurve for all functions is still to be done. Now done via #1134

Taproot support needs to be added, see #1084.

Sending to taproot addresses was included as of v0.9.5.

Extra features.

PayJoin is already implemented, though not in GUI, that could be added. Full BIP78 Payjoin now in GUI also.

Maker functionality is not in GUI, that could quite plausibly be added and is quite widely requested. - See #487, this is now largely functional but still needs work. However this is probably superseded by work on the RPC-API, see above under “Alternative implementations”.

SNICKER exists currently as a proposed code update but is not quite ready, see #403. “Full” SNICKER functionality is now merged via #768, albeit it will need more testing before it can be auto-switched on for mainnet yieldgenerators.

Hardware wallet support is a tough one, but there is some interesting discussion around possibilities, see #663.